588613 - Site permission based notifications need to display under the site identity block after quick dismissal

Status: RESOLVED DUPLICATE of bug 885366

(Firefox :: General, defect)

Description

[Alex Faaborg [:faaborg] (Firefox UX)]

If the user clicks outside of a doorhanger that is requesting a site permission, the exact same UI needs to appear in the site identity panel if the user wishes to bring the notification back (either because they changed their mind about responding, or because they changed they accidentally dismissed the doorhanger and they would like to get it back).

The effected notifications that anchor to the site identity block are:

-Extension Install
-Confirm Locale/Skin
-Offline Storage
-New Feed reader
-Protocol Handler registration

Additionally, a link to the site preferences pane should appear in the site identity panel, so that users can revoke these types of permissions later if they would like. (this will be covered in a separate bug after the site preferences UI lands, but appears in the mockups for clarity).

Note that these doorhanger notifications are not effected because they have their own parent anchor when they are displayed:

-Geolocation
-Password manager (save and change)
-HTTPAUth
-Account manager
-Audio/Video feed

Comment 2

[Mehdi Mulani [:mmm] (I don't check this)]

Attachment: Initial patch with some problems.

Hashed this out quickly to test it, this won't touch browser.xul in the future but instead modify the gIdentityHandler object.

This requires a newer version of SitePrefs (my current revision) that I'll be pushing later.

Comment 3

[Alex Faaborg [:faaborg] (Firefox UX)]

Attachment: Mockup of retrieving a notification from the site identity block

Here is a mockup of how the user can retrieve a dismissed notification that anchors to the site identity block (in this case a request for offline storage).

Comment 4

[Alex Faaborg [:faaborg] (Firefox UX)]

Mehdi, this bug just covers the notification aspect, could you post your patch over to bug 588689

Comment 5

[Mehdi Mulani [:mmm] (I don't check this)]

Comment on attachment 467293 [details] [diff] [review]
Initial patch with some problems.

Moved patch to bug 588613.

Comment 6

[Mehdi Mulani [:mmm] (I don't check this)]

(In reply to comment #5) 
> Moved patch to bug 588613.

Sorry for the spam, meant bug 588689.

Comment 7

[:Margaret Leibovic]

It looks like this bug is invalid, considering popup notifications currently originate from an icon in the location bar, and that icon is the way to bring back the notification after a quick dismissal.

The valid part of this bug (to add access to site preferences from the site identity block) still exists as bug 588689.

Comment 8

[Alex Faaborg [:faaborg] (Firefox UX)]

>It looks like this bug is invalid, considering popup notifications currently >originate from an icon in the location bar

That's because we punted on this bug for Firefox 4 when triaging out the planned functionality.  For this list of very obscure implementation level permissions we don't want to have a fixed icon in the location bar:

-Extension Install
-Confirm Locale/Skin
-Offline Storage
-New Feed reader
-Protocol Handler registration

We only want to give persistent icons to important pieces of information, that involve the user's privacy (physical location, account, streaming audio/video).

Comment 9

[Matthew N. [:MattN]]

Bug 588270 will remove the favicon from the location bar so there will be no click target left (other than with SSL) to show the notifications.

Comment 10

[Matthew N. [:MattN]]

The favicon in the location bar was replaced with a generic icon when using HTTP so this proposed solution is still possible.